gabotechs commented on code in PR #16633:
URL: https://github.com/apache/datafusion/pull/16633#discussion_r2182129668
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -243,7 +243,7 @@ async fn run_test_file_substrait_round_trip(
};
setup_scratch_dir(&relative_path)?;
- let count: u64 = get_record_count(&path,
"DatafusionSubstraitRoundTrip".to_string());
+ let count: u64 = get_record_count(&path, "DataFusion".to_string());
Review Comment:
We are going to need to keep the `"DatafusionSubstraitRoundTrip"` engine
name for the future, we'll want to be able to ignore some statements based on
it, something like:
```
skipif DatafusionSubstraitRoundTrip
```
Instead of changing the engine name, I'd go to the relevant tests in
https://github.com/apache/datafusion/blob/58cc4e1289451b30adca4721fd6eb5a36b26a2cd/datafusion/sqllogictest/test_files/pg_compat/pg_compat_null.slt#L51
And do the following replacement:
```
- onlyif DataFusion
+ skipif postgres
```
That way we maintain the ability to skip specific statements in
`DatafusionSubstraitRoundTrip` mode, while prompting any engine other than
`postgres` to actually try to comply with that test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
