alamb commented on code in PR #16670:
URL: https://github.com/apache/datafusion/pull/16670#discussion_r2183767743
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -895,17 +919,8 @@ fn dict_from_values<K: ArrowDictionaryKeyType>(
}
macro_rules! typed_cast_tz {
- ($array:expr, $index:expr, $ARRAYTYPE:ident, $SCALAR:ident, $TZ:expr) => {{
- use std::any::type_name;
- let array = $array
- .as_any()
- .downcast_ref::<$ARRAYTYPE>()
- .ok_or_else(|| {
- DataFusionError::Internal(format!(
- "could not cast value to {}",
- type_name::<$ARRAYTYPE>()
- ))
- })?;
+ ($array:expr, $index:expr, $array_cast:ident, $SCALAR:ident, $TZ:expr) =>
{{
Review Comment:
❤ this is a nice change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
