alamb commented on code in PR #16694: URL: https://github.com/apache/datafusion/pull/16694#discussion_r2190398395
########## datafusion/sqllogictest/bin/sqllogictests.rs: ########## @@ -689,6 +689,12 @@ struct Options { help = "IGNORED (for compatibility with built-in rust test runner)" )] nocapture: bool, + + #[clap( Review Comment: Another thing we could do (as a follow on PR) is to actually thread this through to the runner: https://github.com/apache/datafusion/blob/eeee6b00a0a0cf1bb449631b57535c06bbf99583/datafusion/sqllogictest/bin/sqllogictests.rs#L197-L196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org