comphead commented on code in PR #16699:
URL: https://github.com/apache/datafusion/pull/16699#discussion_r2190441264
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -137,6 +120,25 @@ SET datafusion.execution.spill_compression = 'zstd';
For more details about this configuration option, including performance
trade-offs between different compression codecs, see the [Configuration
Settings](../user-guide/configs.md) documentation.
+## DataFusion `48.0.1`
+
+### `datafusion.execution.collect_statistics` now defaults to `true`
+
+The default value of the `datafusion.execution.collect_statistics`
configuration
+setting is now true. This change impacts users that use that value directly
and relied
+on its default value being `false`.
+
+This change also restores the default behavior of `ListingTable` to its
previous. If you use it directly
+you can maintain the current behavior by overriding the default value in your
code.
+
+```rust
+# /* comment to avoid running
+ListingOptions::new(Arc::new(ParquetFormat::default()))
+ .with_collect_stat(false)
+ // other options
+# */
Review Comment:
```suggestion
/* comment to avoid running
ListingOptions::new(Arc::new(ParquetFormat::default()))
.with_collect_stat(false)
// other options
*/
```
Not sure why those hashes were needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
