iffyio commented on code in PR #1928:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1928#discussion_r2192773155
##########
tests/sqlparser_postgres.rs:
##########
@@ -2207,19 +2223,31 @@ fn parse_pg_like_match_ops() {
];
for (str_op, op) in pg_like_match_ops {
- let select = pg().verified_only_select(&format!("SELECT 'abc' {}
'a_c%'", &str_op));
+ // Basic binary operator usage
+ let select = pg().verified_only_select(&format!("SELECT 'abc' {str_op}
'a_c%'"));
assert_eq!(
SelectItem::UnnamedExpr(Expr::BinaryOp {
- left: Box::new(Expr::Value(
- (Value::SingleQuotedString("abc".into())).with_empty_span()
- )),
+ left:
Box::new(Expr::Value(single_quoted_string("abc").with_empty_span(),)),
op: op.clone(),
- right: Box::new(Expr::Value(
-
(Value::SingleQuotedString("a_c%".into())).with_empty_span()
- )),
+ right:
Box::new(Expr::Value(single_quoted_string("a_c%").with_empty_span(),)),
}),
select.projection[0]
);
+
+ // Binary operator with ALL operator
+ let select =
Review Comment:
I'm not sure I fully understood the fix, is the issue specific to the `ALL`
and `ANY` functions? the current test doesn't seem to make changes to the [list
of
operators](https://github.com/apache/datafusion-sqlparser-rs/blob/60acdc5bb67383ba0e4b3a6291ca6701ab2ec752/tests/sqlparser_postgres.rs#L2218-L2223)
being tested so that its not clear to me why this test fails without the fix
in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
