ryanschneider commented on code in PR #1927:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1927#discussion_r2193132588
##########
src/dialect/mod.rs:
##########
@@ -1076,6 +1088,15 @@ pub trait Dialect: Debug + Any {
fn supports_comma_separated_drop_column_list(&self) -> bool {
false
}
+
+ /// Returns true if the dialect supports the passed in alias.
+ /// See [IsNotNullAlias].
+ fn supports_is_not_null_alias(&self, alias: IsNotNullAlias) -> bool {
Review Comment:
Hmm, the main issue I see w/ that approach is that technically `x NOTNULL`
is shorthand for `x AS NOTNULL` for dialects that don't support `NOTNULL` but
do support aliases w/o `AS`, so this could be considered a breaking change if a
query happened to by using `NOTNULL` as a column alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
