mbutrovich commented on code in PR #1999:
URL: https://github.com/apache/datafusion-comet/pull/1999#discussion_r2195456222
##########
native/core/src/execution/util/spark_bit_array.rs:
##########
@@ -103,7 +102,7 @@ impl SparkBitArray {
}
pub fn num_words(num_bits: i32) -> i32 {
- bit::ceil(num_bits as usize, 64) as i32
+ usize::div_ceil(num_bits as usize, 64) as i32
Review Comment:
Could you add a TODO to remove the cast if i32's div_ceil ever lands in
stable with a link to docs?
https://doc.rust-lang.org/std/primitive.i32.html#method.div_ceil
Otherwise this LGTM! Thanks for the cleanup @tglanz! I love a good negative
line count PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
