alamb commented on PR #16750: URL: https://github.com/apache/datafusion/pull/16750#issuecomment-3070675944
> Somewhat unrelated, but maybe something like the following would be cleaner (untested)? > > ```rust > trait TableProvider: TableSource { > // only scan and get_table_definition > } > ``` > > It would be a breaking change, but it's not a difficult migration (you just add an `impl TableSource for MyTableProvider` and move the other methods there). I agree this would be better still -- I suggest we look into this as a follow on PR (and file a ticket to prevent it from being lost) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org