blaginin commented on PR #16752:
URL: https://github.com/apache/datafusion/pull/16752#issuecomment-3070715362
Thanks for working on this, @geetanshjuneja! I think a bit more work is
needed as it's still failing right now:
```
➜ datafusion git:(handle_backtrace) ✗ RUST_BACKTRACE=1 cargo test -p
datafusion-cli --features backtrace
test test_cli_top_memory_consumers::case_1 ... FAILED
test test_cli_top_memory_consumers::case_2 ... FAILED
test test_cli_top_memory_consumers::case_3 ... FAILED
failures:
---- test_cli_top_memory_consumers::case_1 stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot Summary
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot file:
datafusion-cli/tests/snapshots/cli_top_memory_consumers@no_track.snap
Snapshot: cli_top_memory_consumers@no_track
Source: datafusion-cli/tests/cli_integration.rs:159
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
program: datafusion-cli
args:
- "--memory-limit"
- 10M
- "--command"
- "select * from generate_series(1,500000) as t1(v1) order by v1;"
- "--top-memory-consumers"
- "0"
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
2 2 │ ----- stdout -----
3 3 │ [CLI_VERSION]
4 4 │ Error: Not enough memory to continue external sort. Consider
increasing the memory limit, or decreasing sort_spill_reservation_bytes
5 5 │ caused by
6 │-Resources exhausted: Failed to allocate
7 │-
8 │------ stderr -----
6 │+Resources exhausted: Failed to allocate
────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
