rishvin commented on code in PR #1997: URL: https://github.com/apache/datafusion-comet/pull/1997#discussion_r2208977125
########## native/Cargo.toml: ########## @@ -38,8 +38,8 @@ arrow = { version = "55.1.0", features = ["prettyprint", "ffi", "chrono-tz"] } async-trait = { version = "0.1" } bytes = { version = "1.10.0" } parquet = { version = "55.1.0", default-features = false, features = ["experimental"] } -datafusion = { version = "48.0.0", default-features = false, features = ["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] } -datafusion-spark = { version = "48.0.0" } +datafusion = { git = "https://github.com/apache/datafusion", rev = "3291e4e", default-features = false, features = ["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] } Review Comment: The title mentions `Upgrade to the official Datafusion 49.0.0 release`, however it looks like version 49.0.0 hasn't been officially released yet ([apache/datafusion#16235](https://github.com/apache/datafusion/issues/16235))? Will this change be on hold until the release is finalized? Or is the plan to update Comet to revision `3291e4e` in this PR, and then follow up with a separate PR once `49.0.0` is released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org