viirya commented on issue #16800: URL: https://github.com/apache/datafusion/issues/16800#issuecomment-3082735431
So the basic idea, as I understand it, is that instead of adapting the data batch using `SchemaAdapter` against the schema, the new approach involves rewriting or transforming the physical expressions using `PhysicalExprAdapter`. > There are multiple reasons for this: Based on this reasoning, I think the first two points make sense. Could you clarify the latter two? From your description, they sound like areas where `PhysicalExprAdapter` could bring benefits — but I'm not quite sure how `SchemaAdapter` fits into those cases. Are these scenarios where the current use of `SchemaAdapter` is actually blocking progress toward those goals, and replacing it with `PhysicalExprAdapter` is part of the solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
