LiaCastaneda commented on code in PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#discussion_r2215099809
##########
datafusion/substrait/src/logical_plan/producer/types.rs:
##########
@@ -96,7 +96,15 @@ pub(crate) fn to_substrait_type(
nullability,
})),
}),
- // Float16 is not supported in Substrait
+ // Float16 is not supported in Substrait, use UserDefined type
+ DataType::Float16 => Ok(substrait::proto::Type {
+ kind: Some(r#type::Kind::UserDefined(r#type::UserDefined {
+ type_reference: FLOAT16_TYPE_REF,
+ type_variation_reference: 0,
Review Comment:
should we use `DEFAULT_TYPE_VARIATION_REF`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
