iffyio commented on code in PR #1947:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1947#discussion_r2218870693


##########
src/ast/ddl.rs:
##########
@@ -351,6 +351,13 @@ pub enum AlterTableOperation {
     ValidateConstraint {
         name: Ident,
     },
+    /// `SET ( storage_parameter [= value] [, ... ] )`
+    ///
+    /// Note: this is a PostgreSQL-specific operation.
+    /// Please refer to [PostgreSQL 
documentation](https://www.postgresql.org/docs/current/sql-altertable.html)

Review Comment:
   ```suggestion
       /// Arbitrary parenthesized `SET` options.
       ///
       /// Example:
       /// ```sql
       /// SET (scale_factor = 0.01, threshold = 500)`
       /// ```
       /// 
[PostgreSQL](https://www.postgresql.org/docs/current/sql-altertable.html)
   ```
   Can we change to something more generic like the following?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to