findepi commented on code in PR #16846:
URL: https://github.com/apache/datafusion/pull/16846#discussion_r2223250443
##########
docs/source/library-user-guide/functions/adding-udfs.md:
##########
@@ -419,6 +432,7 @@ impl ScalarUDFImpl for AsyncUpper {
Ok(DataType::Utf8)
}
+ // Note the normal invoke_with_args method is not called for Async UDFs
Review Comment:
We certainly should.
The functions we plug into LP shouldn't have to answer things like name,
aliases, description, schema_name.
It's SQL frontend stuff, not the LP stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
