comphead commented on code in PR #2039:
URL: https://github.com/apache/datafusion-comet/pull/2039#discussion_r2223413371
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -378,3 +378,38 @@ object CometCreateArray extends CometExpressionSerde {
}
}
}
+
+object CometFlatten extends CometExpressionSerde {
+
+ @tailrec
+ def isTypeSupported(dt: DataType): Boolean = {
Review Comment:
I think we should finally move this method to utility class instead of
copying it over array funcs, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
