lorenarosati opened a new pull request, #16857:
URL: https://github.com/apache/datafusion/pull/16857
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #16363.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Virtual tables in Substrait can have either literal values or expressions,
and currently, the Substrait consumer only handles the case when values are
provided ([values is a deprecated
field](https://github.com/substrait-io/substrait/blob/793c64ba26e337c22f5e91b658be58b1eea7efd3/proto/substrait/algebra.proto#L152)).
If there are no values provided, an empty relation is returned, even if the
virtual table has expressions specified.
If expressions are provided as elements in a virtual table (rather than
literal values), from_read_rel() should return a LogicalPlan with the virtual
table elements rather than an empty relation.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Only returns an empty relation if there are no values _and_ no expressions
specified.
- If expressions is non-empty, we iterate through the records and consume
each expression; if expressions is empty, we fallback to iterate through the
records and consume each literal.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
These changes will allow users to specify expressions in Substrait virtual
tables, and get a result from their query.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
