iffyio commented on code in PR #1960:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1960#discussion_r2226064958
##########
tests/sqlparser_snowflake.rs:
##########
@@ -1104,6 +1066,56 @@ fn
parse_sf_create_table_or_view_with_dollar_quoted_comment() {
);
}
+#[test]
+fn parse_create_dynamic_table() {
Review Comment:
Can we include scenarios for the `BEFORE` and `RefreshMode` variants? those
don't seem to be covered by the existing tests?
##########
tests/sqlparser_snowflake.rs:
##########
@@ -1104,6 +1066,56 @@ fn
parse_sf_create_table_or_view_with_dollar_quoted_comment() {
);
}
+#[test]
+fn parse_create_dynamic_table() {
+ snowflake().verified_stmt(r#"CREATE OR REPLACE DYNAMIC TABLE
my_dynamic_table TARGET_LAG='20 minutes' WAREHOUSE=mywh AS SELECT product_id,
product_name FROM staging_table"#);
+ snowflake()
+ .parse_sql_statements(
Review Comment:
For the usages of `parse_sql_statements` can we instead use
`snowflake().one_statement_parses_to(sql, canonical)` in the cases that
`verified_stmt` isnt applicable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
