zhuqi-lucas commented on issue #16884:
URL: https://github.com/apache/datafusion/issues/16884#issuecomment-3112820582
I believe we default Value to Utf8 currently in datafusion, i am ok if we
change to Utf8View for Value, but we need to verify the benchmark result:
```rust
impl FromStr for ScalarValue {
type Err = Infallible;
fn from_str(s: &str) -> Result<Self, Self::Err> {
Ok(s.into())
}
}
impl From<String> for ScalarValue {
fn from(value: String) -> Self {
ScalarValue::Utf8(Some(value))
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
