Standing-Man commented on code in PR #16848:
URL: https://github.com/apache/datafusion/pull/16848#discussion_r2230260434
##########
datafusion/sqllogictest/test_files/spark/string/luhn_check.slt:
##########
@@ -35,3 +35,140 @@
## PySpark 3.5.5 Result: {'luhn_check(8112189876)': True,
'typeof(luhn_check(8112189876))': 'boolean', 'typeof(8112189876)': 'string'}
#query
#SELECT luhn_check('8112189876'::string);
+
Review Comment:
I agree — the commented-out test cases seem redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
