waynexia opened a new issue, #16917: URL: https://github.com/apache/datafusion/issues/16917
### Is your feature request related to a problem or challenge? I find some old helper functions are no longer needed or recommended for use. For example, `physical_exprs_contains` only has one reference from `get_aggregate_expr_req` and may be replaced with an `IndexSet`. `physical_exprs_bag_equal` only has one reference from `InListExpr`. https://github.com/apache/datafusion/blob/bb1b55cfba27a0b3090aa114ff7e05be1a039252/datafusion/physical-expr/src/physical_expr.rs#L54-L63 And `physical_exprs_equal` is not necessary to exist https://github.com/apache/datafusion/blob/bb1b55cfba27a0b3090aa114ff7e05be1a039252/datafusion/physical-expr/src/physical_expr.rs#L65-L71 ### Describe the solution you'd like - Most of them are like substitutes before we have https://github.com/apache/datafusion/pull/13005, and are either not necessary or may indicate something can be improved at present. Would like to raise this ticket as a discussion to remove or deprecate them. ### Describe alternatives you've considered _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
