alamb commented on code in PR #16861:
URL: https://github.com/apache/datafusion/pull/16861#discussion_r2231863904
##########
datafusion/physical-optimizer/src/filter_pushdown.rs:
##########
@@ -485,21 +497,32 @@ fn push_down_filters(
// currently. `self_filters` are the predicates which are provided by
the current node,
// and tried to be pushed down over the child similarly.
- let num_self_filters = self_filters.len();
- let mut all_predicates = self_filters.clone();
+ // Filter out self_filters that contain volatile expressions and track
indices
Review Comment:
I think it is better than the current inlined implementation FWIW - even if
it is somewhat mindblowing
##########
datafusion/physical-optimizer/src/filter_pushdown.rs:
##########
@@ -485,21 +497,32 @@ fn push_down_filters(
// currently. `self_filters` are the predicates which are provided by
the current node,
// and tried to be pushed down over the child similarly.
- let num_self_filters = self_filters.len();
- let mut all_predicates = self_filters.clone();
+ // Filter out self_filters that contain volatile expressions and track
indices
Review Comment:
I think it is better than the current inlined implementation FWIW - even if
it is somewhat mindblowing at least the mind blowingness is documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
