parthchandra commented on code in PR #2037: URL: https://github.com/apache/datafusion-comet/pull/2037#discussion_r2232007462
########## spark/src/main/scala/org/apache/comet/serde/nondetermenistic.scala: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.serde + +import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression, Literal, MonotonicallyIncreasingID, Rand, Randn, SparkPartitionID} + +object CometSparkPartitionId extends CometExpressionSerde { + override def convert( + expr: Expression, + _inputs: Seq[Attribute], + _binding: Boolean): Option[ExprOuterClass.Expr] = { + assert(expr.isInstanceOf[SparkPartitionID]) + Some( + ExprOuterClass.Expr + .newBuilder() + .setSparkPartitionId(ExprOuterClass.EmptyExpr.newBuilder()) Review Comment: Sorry, I'm not very familiar with this part of Spark but from what I understand, `spark_partition_id` returns the partition id this expression is being executed in. This serde is simply setting an empty expression (which makes sense because the partition id is not known at this time); but how is this evaluated in the native code at runtime ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
