comphead commented on code in PR #16910:
URL: https://github.com/apache/datafusion/pull/16910#discussion_r2233109532
##########
datafusion/physical-expr/src/equivalence/class.rs:
##########
@@ -851,6 +851,26 @@ impl EquivalenceGroup {
.zip(right_children)
.all(|(left_child, right_child)| self.exprs_equal(left_child,
right_child))
}
+
+ /// Determine whether fields at indices `lhs` and `rhs` are equal.
+ pub fn fields_equal(&self, lhs: usize, rhs: usize) -> bool {
Review Comment:
I'm little bit struggling to understand what kind of indices are `lhs` and
`rhs`, this is a `pub` method, should we explain more in comments what those
indices are?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
