iffyio commented on code in PR #1969:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1969#discussion_r2236616269


##########
tests/sqlparser_common.rs:
##########
@@ -11022,6 +11022,67 @@ fn parse_unpivot_table() {
         verified_stmt(sql_unpivot_include_nulls).to_string(),
         sql_unpivot_include_nulls
     );
+
+    let sql_unpivot_with_alias = concat!(

Review Comment:
   Ah I see, spark dialect isn't a supported by the parser currently so I'm not 
sure that we can merge this changes without repercussions later on e.g. if we 
hit scenarios with ambiguous syntax



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to