iffyio commented on code in PR #1979:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1979#discussion_r2236697235
##########
src/dialect/mod.rs:
##########
@@ -841,6 +841,12 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Returns true if this dialect allow colon placeholders
+ /// e.g. `SELECT :var` (JPA named parameters)
+ fn supports_colon_placeholder(&self) -> bool {
+ false
+ }
Review Comment:
> in fact, sqlparser's
[parser](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/parser/mod.rs#L9591)
combines a colon token followed by a word token into a placeholder, but does
not adjust the span of the resulting ast node :/ and allows for whitespace
between the colon and the word.
@xitep could you elaborate on this part? I'm not sure I followed the intent,
is my understanding correct that currently the parser indeed handles e.g.
`SELECT :var`? If so what's the requirement for the tokenizer updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
