adriangb opened a new pull request, #16948: URL: https://github.com/apache/datafusion/pull/16948
Minor drive by, aside from compiling an extra function if used (current codebases won't) and a bit of extra compile work this should have not negative impact. Our pattern is to build a `Vec<String>` in places and it's pretty annoying to go from `Vec<String>` -> `&[&str]` since you have to build up a `Vec<&str>` and keep the reference to the `Vec<String>` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
