Adez017 commented on PR #97: URL: https://github.com/apache/datafusion-site/pull/97#issuecomment-3131937805
> Thank you @Adez017 -- this is a great start to a blog. I pushed a few more links to the intro and background > > I think it would be best if we could improve the examples before publishing this. Please let me know what you think. > > I have two major comments: > > ## Apply to the motivating example? > The post says: > > > DataFusion provides an excellent example of custom SQL dialect implementation in their [sql_dialect.rs] example. Let's break down how it works and then apply the pattern to our `ATTACH DATABASE` use case. > > I didn't see any mention / examples of how to use the ATTACH DATABASE syntax > > ## The COPY TO parser example is strange > I tried the example for COPY TO in the sql and it basically worked without a custom parser: > > ```sql > > create table source_table as values (1); > 0 row(s) fetched. > Elapsed 0.002 seconds. > > > COPY source_table TO 'file.fasta' STORED AS FASTA; > Error during planning: There is no registered file format with ext fasta > ``` > > (I would expect a parser error for a statement) I know this is not anything introduced by this post. > > What would you think about updating the sql_parser.rs example to do something more exciting, such as either: > > 1. Actually implementing the motivating example from this blog post > > ```sql > CREATE EXTERNAL CATALOG my_catalog > STORED AS PARQUET > LOCATION 's3://my-bucket/data/' > OPTIONS ( > 'aws.region' = 'us-west-2', > 'catalog.type' = 'hive_metastore' > ); > ``` > > 2. Implementing the `ATTACH` and `DETACH` statements from DuckDB? > > https://duckdb.org/docs/stable/sql/statements/attach.html Thanks @alamb , i think the its a great idea we can follow up along . and it would be great start -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
