alamb commented on code in PR #16954:
URL: https://github.com/apache/datafusion/pull/16954#discussion_r2240550577
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -944,6 +949,53 @@ impl ExecutionPlan for HashJoinExec {
try_embed_projection(projection, self)
}
}
+
+ fn gather_filters_for_pushdown(
+ &self,
+ phase: FilterPushdownPhase,
+ parent_filters: Vec<Arc<dyn PhysicalExpr>>,
+ _config: &ConfigOptions,
+ ) -> Result<FilterDescription> {
+ if self.join_type != JoinType::Inner {
Review Comment:
I recommend we file a ticket and then add a reference to that ticket in the
code a ticket reference so someone in the future who stumbles on this code can
locate the relevant context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
