zhuqi-lucas commented on code in PR #16925:
URL: https://github.com/apache/datafusion/pull/16925#discussion_r2241480549
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -103,21 +103,38 @@ pub fn create_window_expr(
window_frame: Arc<WindowFrame>,
input_schema: &Schema,
ignore_nulls: bool,
+ distinct: bool,
) -> Result<Arc<dyn WindowExpr>> {
Ok(match fun {
WindowFunctionDefinition::AggregateUDF(fun) => {
- let aggregate = AggregateExprBuilder::new(Arc::clone(fun),
args.to_vec())
- .schema(Arc::new(input_schema.clone()))
- .alias(name)
- .with_ignore_nulls(ignore_nulls)
- .build()
- .map(Arc::new)?;
- window_expr_from_aggregate_expr(
- partition_by,
- order_by,
- window_frame,
- aggregate,
- )
+ if distinct {
Review Comment:
Thank you @Omega359 for good suggestion and review, i will address it in any
follow-up PR for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
