xitep commented on code in PR #1979:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1979#discussion_r2241729326
##########
src/tokenizer.rs:
##########
@@ -1756,6 +1761,30 @@ impl<'a> Tokenizer<'a> {
}
}
+ /// Tokenizes an identifier followed immediately after a colon,
+ /// aka named query parameter, e.g. `:name`. The next char of the
+ /// processed char stream is to be an alphabetic - panics otherwise.
+ fn tokenize_colon_preceeded_placeholder(
Review Comment:
* wrt `tokenize_identifier_or_keyword` ... i guess it would make it quite
hard to support the `$` then as part of the identifier (if enabled by
`Dialect::supports_dollar_placeholder`
https://docs.rs/sqlparser/latest/sqlparser/dialect/trait.Dialect.html#method.supports_dollar_placeholder.)
i see the placeholder identifiers distinct (ie. with different restrictions)
from other SQL identifiers.
* thanks for the heads-up; the panic here would be a programming error, as
that contract says that the caller must make sure ... but I'm fine with the
established convention and would make it return an error instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
