Thearas commented on code in PR #16986:
URL: https://github.com/apache/datafusion/pull/16986#discussion_r2244568290
##########
datafusion-examples/examples/composed_extension_codec.rs:
##########
@@ -233,6 +234,17 @@ impl PhysicalExtensionCodec for
ChildPhysicalExtensionCodec {
}
}
+/// BlobFormatProto captures data encoded by blob format codecs
+#[derive(Clone, PartialEq, prost::Message)]
+struct BlobFormatProto {
+ /// encoder id used to encode blob
+ /// (to be used for decoding)
+ #[prost(uint32, tag = 1)]
+ pub encoder_position: u32,
+ #[prost(bytes, tag = 2)]
+ pub blob: Vec<u8>,
+}
Review Comment:
OK, naming is hard. What name would you suggest?
Maybe `DataWithEncoderPositionProto`😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
