alamb commented on PR #16977: URL: https://github.com/apache/datafusion/pull/16977#issuecomment-3141100594
The planner benchmarks look good across the board except for ``` logical_select_all_from_1000 1.04 11.5±0.09ms ? ?/sec 1.00 11.0±0.04ms ? ?/sec ``` I was actually able to reproduce this locally on my laptop using: ```shell git checkout main cargo bench --bench sql_planner -- logical_select_all_from_1000 gh pr checkout https://github.com/apache/datafusion/pull/16977 cargo bench --bench sql_planner -- logical_select_all_from_1000 ``` I wonder if it could be something related to the switch to using ahash 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
