alamb commented on code in PR #16995:
URL: https://github.com/apache/datafusion/pull/16995#discussion_r2248489786
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -1045,6 +1046,37 @@ impl PlanProperties {
}
}
+macro_rules! check_len {
+ ($target:expr, $func_name:ident, $expected_len:expr) => {
+ let actual_len = $target.$func_name().len();
+ if actual_len != $expected_len {
+ return internal_err!(
+ "{}::{} returned Vec with incorrect size: {} != {}",
+ $target.name(),
+ stringify!($func_name),
+ actual_len,
+ $expected_len
+ );
+ }
+ };
+}
+
+/// Checks a set of invariants that apply to all ExecutionPlan implementations.
+/// Returns an error if the given node does not conform.
+pub fn check_default_invariants<P: ExecutionPlan + ?Sized>(
Review Comment:
👍 this is a good one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
