iffyio commented on code in PR #1989:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1989#discussion_r2249137924
##########
src/parser/mod.rs:
##########
@@ -7708,6 +7708,9 @@ impl<'a> Parser<'a> {
while let Some(option) = self.parse_plain_option()? {
options.push(option);
+ if self.dialect.supports_comma_separated_create_table_options() {
+ let _ = self.consume_token(&Token::Comma);
+ }
Review Comment:
Thinking since the syntax wouldn't conflict with other dialects we can skip
the dialect option and have the parser always consume the comma if it shows up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
