acking-you commented on code in PR #16930:
URL: https://github.com/apache/datafusion/pull/16930#discussion_r2249190771
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -375,7 +375,19 @@ impl PhysicalExpr for BinaryExpr {
// as it takes into account cases where the selection contains
null values.
let batch = filter_record_batch(batch, selection)?;
let right_ret = self.right.evaluate(&batch)?;
- return pre_selection_scatter(selection, right_ret);
+ match &right_ret {
+ ColumnarValue::Array(array) => {
+ return pre_selection_scatter(selection,
array.as_boolean());
+ }
+ ColumnarValue::Scalar(scalar) => {
+ if let ScalarValue::Boolean(v) = scalar {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
