alamb commented on code in PR #16690:
URL: https://github.com/apache/datafusion/pull/16690#discussion_r2249203274
##########
datafusion/common/src/config.rs:
##########
@@ -601,13 +601,6 @@ config_namespace! {
/// default parquet writer setting
pub statistics_enabled: Option<String>, transform = str::to_lowercase,
default = Some("page".into())
- /// (writing) Sets max statistics size for any column. If NULL, uses
- /// default parquet writer setting
- /// max_statistics_size is deprecated, currently it is not being used
- // TODO: remove once deprecated
- #[deprecated(since = "45.0.0", note = "Setting does not do anything")]
Review Comment:
these were removed from the underlying parquet library as well
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -2192,6 +2191,16 @@ impl ScalarValue {
}
let array: ArrayRef = match &data_type {
+ DataType::Decimal32(_precision, _scale) => {
Review Comment:
Decimal323 and Decimal64 types were added to arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
