parthchandra opened a new pull request, #2078:
URL: https://github.com/apache/datafusion-comet/pull/2078

   ## Which issue does this PR close?
   When running iceberg unit and integration tests with Comet, we still 
encounter some issues due to Parquet shading. This PR addresses those issues.
   The main changes are: For all classes in Comet that are used in Iceberg 
integration, make all constructors and methods package private if they have a 
Parquet class in the signature. Provide equivalent methods that use Parquet 
encapsulation classes.
   Refactor the `FileReader` API to use an `InputStream` (instead of a file 
path) to allow implementations of Iceberg's `InputFile`. The refactoring 
introduces some more encapsulation classes that use reflection to call back 
into Iceberg (to avoid adding a circular dependency on Iceberg)
   This PR may break the complementary (draft) PR in Iceberg: 
https://github.com/apache/iceberg/pull/13378
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to