adamreeve commented on code in PR #16779:
URL: https://github.com/apache/datafusion/pull/16779#discussion_r2250199998
##########
datafusion/common/src/file_options/parquet_writer.rs:
##########
@@ -96,13 +95,11 @@ impl TryFrom<&TableParquetOptions> for
WriterPropertiesBuilder {
global,
column_specific_options,
key_value_metadata,
- crypto,
+ crypto: _,
Review Comment:
No they are still used, but I wanted to keep the logic for creating the
`FileEncryptionProperties` in once place, so after `try_from` is called,
there's a new `set_writer_encryption_properties` method that will either use
the existing `ConfigFileEncryptionProperties` or the new factory:
https://github.com/adamreeve/datafusion/blob/b42f21ddf7dd01991e576dc34472db010dc23012/datafusion/datasource-parquet/src/file_format.rs#L1327-L1334
I couldn't include this logic in the `try_from` implementation as it
requires some other data from outside the `TableParquetOptions`.
I guess this could be a little bit surprising if a user expects `try_from`
to be non-lossy. I could probably restore the old behaviour of using the
`ConfigFileEncryptionProperties` here, ~~or just add a comment about this?~~.
I've added a comment about this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
