alamb commented on code in PR #17065: URL: https://github.com/apache/datafusion/pull/17065#discussion_r2259957646
########## datafusion/functions-aggregate/src/array_agg.rs: ########## @@ -227,6 +227,8 @@ impl AggregateUDFImpl for ArrayAgg { fn documentation(&self) -> Option<&Documentation> { self.doc() } + + udf_equals_hash!(AggregateUDFImpl); Review Comment: Should the equal method also check `is_input_pre_ordered` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org