mbutrovich commented on code in PR #2090:
URL: https://github.com/apache/datafusion-comet/pull/2090#discussion_r2261391774
##########
native/core/src/common/buffer.rs:
##########
@@ -202,7 +165,7 @@ impl CometBuffer {
/// with 0. if `new_capacity` is less than the current capacity of this
buffer, this is a no-op.
#[inline(always)]
Review Comment:
I'm always a bit skeptical when I see an `#[inline(always)]` but this
instance seems to pass the smell test. I know it's not your code, just noticing
on the changes page since it's next to a diff'd line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
