comphead commented on code in PR #2057: URL: https://github.com/apache/datafusion-comet/pull/2057#discussion_r2261309699
########## native/proto/src/proto/types.proto: ########## @@ -0,0 +1,41 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + + + +syntax = "proto3"; + +package spark.spark_expression; + +option java_package = "org.apache.comet.serde"; + +message ListLiteral { + // Only one of these fields should be populated based on the array type + repeated bool boolean_values = 1; + repeated int32 byte_values = 2; + repeated int32 short_values = 3; + repeated int32 int_values = 4; + repeated int64 long_values = 5; + repeated float float_values = 6; + repeated double double_values = 7; + repeated string string_values = 8; + repeated bytes bytes_values = 9; + repeated bytes decimal_values = 10; + repeated ListLiteral list_values = 11; Review Comment: correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
