andygrove commented on code in PR #2073:
URL: https://github.com/apache/datafusion-comet/pull/2073#discussion_r2261755864
##########
native/core/src/execution/planner.rs:
##########
@@ -231,7 +231,7 @@ impl PhysicalPlanner {
) -> Result<Arc<dyn PhysicalExpr>, ExecutionError> {
match spark_expr.expr_struct.as_ref().unwrap() {
ExprStruct::Add(expr) => {
- // TODO respect eval mode
+ // TODO respect ANSI eval mode
// https://github.com/apache/datafusion-comet/issues/2021
// https://github.com/apache/datafusion-comet/issues/536
let _eval_mode = from_protobuf_eval_mode(expr.eval_mode)?;
Review Comment:
Please remove the leading `_` from the variable name now that we are using
the variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
