findepi commented on PR #17074: URL: https://github.com/apache/datafusion/pull/17074#issuecomment-3166666368
> the new function does not by default delegate to the previously-internally-used function Typically the new function delegates to the old one and the old one gets deprecated. If that's not possible, adding such new function is a breaking API change. In such case, graceful deprecation of the old function doesn't help, and actually makes situation worse, as you said -- no compiler's help. Given exactly this was the case with `ScalarUDFImpl::is_nullable` in https://github.com/apache/datafusion/commit/d3f1c9ad026e181e8cc6d1121f3223be5c26c3ae, I suggest removal of the `is_nullable` function. However, I don't have full context and I am not the author of that change. @Blizzara do you want to make a follow-on PR with the removal? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
