shehabgamin commented on code in PR #17022: URL: https://github.com/apache/datafusion/pull/17022#discussion_r2262208618
########## datafusion/datasource-parquet/src/mod.rs: ########## @@ -24,7 +24,7 @@ pub mod file_format; mod metrics; mod opener; mod page_filter; -mod reader; +pub mod reader; Review Comment: So downstream crates can use it. The reader file looked like it could generally be useful for downstream crates which is why I made the entire reader public. Currently in Sail we build our own cache for each cache type in `CacheManagerConfig`. I was unable to access `CachedParquetMetaData` to do something like the following unless I made `CachedParquetMetaData` public ([full code](https://github.com/lakehq/sail/pull/687/files#diff-6bdfe8a2d91d5871364cdfb1cba0ae7138850b71d6a164e8daa1f774ca8e1c50)): ``` if let Some(parquet_metadata) = value.1.as_any().downcast_ref::<CachedParquetMetaData>() { parquet_metadata .parquet_metadata() .memory_size() .min(u32::MAX as usize) } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
