findepi commented on PR #17078: URL: https://github.com/apache/datafusion/pull/17078#issuecomment-3169039418
> `a == b` will effectively call `PartialEq` yes > and we dont need separate impl for `Eq`? `Eq` is a marker trait. Implementing `Eq` is a promise that `PartialEq` is a well-behaved equality, including reflexivity (`a == a` for every `a`). The `DynEq` trait used in `PhysicalExpr` definition currently lacks any verbal contract, but it can be reasonably expected that it behaves as `Eq`, including reflexivity. This conclusion is based on the blanked implementation: `impl<T: Eq + Any> DynEq for T`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
