zhuqi-lucas commented on PR #17105: URL: https://github.com/apache/datafusion/pull/17105#issuecomment-3170564243
> Thank you @zhuqi-lucas -- this looks great > > As long as the benchmarks look good (I expect no substantial change) I think we should merge this Thank you @alamb for review, my follow-up plan, correct me if i am wrong: 1. I will try to address this comments from @Dandandan https://github.com/apache/datafusion/pull/16249#issuecomment-2974721937 for this PR or follow-up to improve performance. 2. Optimize the push_batch_with_filter performance, i can start from primitive type: https://github.com/apache/arrow-rs/issues/7762 3. I can investigate try to change filter_exec with coalesce_batch_exec to coalesce_batch_exec(with filter) which can use upstream push_batch_with_filter, we may can remove coalesce_batch_exec operator in future? 4. Apply to other combination with coalesce_batch_exec, such HashJoinExec, RepartitionExec, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
