Jefffrey commented on code in PR #17109:
URL: https://github.com/apache/datafusion/pull/17109#discussion_r2265133603
##########
datafusion/sqllogictest/src/engines/datafusion_engine/error.rs:
##########
@@ -28,7 +28,7 @@ pub type Result<T, E = DFSqlLogicTestError> =
std::result::Result<T, E>;
pub enum DFSqlLogicTestError {
/// Error from sqllogictest-rs
#[error("SqlLogicTest error(from sqllogictest-rs crate): {0}")]
- SqlLogicTest(#[from] TestError),
+ SqlLogicTest(#[from] Box<TestError>),
Review Comment:
I don't think this matters too much since it's sqllogictest stuff?
##########
clippy.toml:
##########
@@ -9,4 +9,14 @@ disallowed-types = [
# Lowering the threshold to help prevent stack overflows (default is 16384)
# See: https://rust-lang.github.io/rust-clippy/master/index.html#/large_futures
-future-size-threshold = 10000
\ No newline at end of file
+future-size-threshold = 10000
+
+# Be more aware of large error variants which can impact the "happy path" due
+# to large stack footprint when considering async state machines (default is
128).
+#
+# Value of 70 picked arbitrarily as something less than 100.
+#
+# See:
+# - https://github.com/apache/datafusion/issues/16652
+# - https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
+large-error-threshold = 70
Review Comment:
Initially I picked 64, but there were some error variants that were
_exactly_ 64 and got flagged, hence increased to 70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
