alamb commented on code in PR #16049:
URL: https://github.com/apache/datafusion/pull/16049#discussion_r2265221650
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -978,7 +978,11 @@ impl OptimizerRule for PushDownFilter {
let group_expr_columns = agg
.group_expr
.iter()
- .map(|e|
Ok(Column::from_qualified_name(e.schema_name().to_string())))
+ .map(|e| {
+ Ok(Column::from_qualified_name_ignore_case(
Review Comment:
I need to study this more carefully, but this change to ignore case seems
inconsistent with the rest of this file and also potentially incorrect
For example:
* In for dialects where case is not important, universally ignoring the case
could push down the wrong fields
* For dialects where case is important, there seem to be many other places
in this module that do not compare the case 🤔
So it seems:
1. We should be checking the case sensitivity config setting before comparing
2. Are there other places that should be changed to take name into account 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
