andygrove commented on code in PR #2098:
URL: https://github.com/apache/datafusion-comet/pull/2098#discussion_r2267070320
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -852,62 +852,6 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
}
- case Like(left, right, escapeChar) =>
- if (escapeChar == '\\') {
- createBinaryExpr(
- expr,
- left,
- right,
- inputs,
- binding,
- (builder, binaryExpr) => builder.setLike(binaryExpr))
- } else {
- // TODO custom escape char
- withInfo(expr, s"custom escape character $escapeChar not supported
in LIKE")
- None
- }
-
- case RLike(left, right) =>
- // we currently only support scalar regex patterns
- right match {
- case Literal(pattern, DataTypes.StringType) =>
- if (!RegExp.isSupportedPattern(pattern.toString) &&
- !CometConf.COMET_REGEXP_ALLOW_INCOMPATIBLE.get()) {
Review Comment:
Thanks for catching this! PR
https://github.com/apache/datafusion-comet/pull/2068 was supposed to move code
without making functional changes, but it changed the logic here inadvertently.
I have updated this PR to revert that change in the new version of the
expression handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
