findepi commented on issue #17120:
URL: https://github.com/apache/datafusion/issues/17120#issuecomment-3176139862
> The tests should pass -- assuming the the new queries passing are an
improvement I think we should probably update the expected output
I run
```bash
datafusion main$ git rev-parse HEAD
14fb4a3c7d174edde53b429c2aafb695e4511a5c
datafusion main$ env RUST_MIN_STACK=30485760 INCLUDE_SQLITE=true cargo test
--test sqllogictests -- --complete --include-sqlite
```
And this produced some weird changes in `datafusion-testing` submodule, e.g.
```diff
diff --git data/sqlite/index/orderby_nosort/10/slt_good_0.slt
data/sqlite/index/orderby_nosort/10/slt_good_0.slt
index cf8125f..f25ea55 100644
--- data/sqlite/index/orderby_nosort/10/slt_good_0.slt
+++ data/sqlite/index/orderby_nosort/10/slt_good_0.slt
@@ -177,402 +177,302 @@ SELECT pk FROM tab4 WHERE col1 > 71.33 ORDER BY 1
query II nosort label-10-1-desc
SELECT pk, col0 FROM tab0 WHERE col1 > 71.33 ORDER BY 1 DESC
----
-4
-20
-3
-96
+4 20
+3 96
...
```
(great many of changes, including many as the one above)
What's the correct way to update the expected outputs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
